[Solved] - DSDT - MacIASL does not allow me to apply the patch

Was this thread helpful?

  • Yes

    Votes: 0 0.0%
  • Partially

    Votes: 0 0.0%
  • No

    Votes: 0 0.0%

  • Total voters
    0
Status
Not open for further replies.

yigitkerem

Member
Joined
Mar 17, 2020
Motherboard
Lenovo V110-15IKB
CPU
i5-7200U
Graphics
UHD 620 + Disabled AMD R7 M240
OS X/macOS
10.15 (Beta)
Bootloader
Clover (UEFI)
Mobile Phone
iOS
Hi I've been following your guide on Fixing The Brightness Keys with BRT6.
I have created the following origin folder and opened SSDT-10-Sfgh.dsl and DSDT.dsl clicked patch pasted following but apply button got disabled.
If somebody can patch or can tell me what the problem is I'll be really happy.
Code:
into method label BRT6 replace_content
begin
    If (LEqual (Arg0, One))\n
    {\n
// Brightness Up\n
        Notify (^^LPCB.PS2K, 0x0406)\n
    }\n
    If (And (Arg0, 0x02))\n
    {\n
// Brightness Down\n
        Notify (^^LPCB.PS2K, 0x0405)\n
    }\n
end;
 

Attachments

EliteMacx86

Administrator
Staff member
Joined
Jul 22, 2018
Motherboard
GIGABYTE Z370 AROUS GAMING 3
CPU
Intel Core i9 9900K
Graphics
2xAMD RX 580 8GB
OS X/macOS
10.14.6
Bootloader
Clover (UEFI)
Mac
MacBook Pro
Mobile Phone
Android, iOS
Hi I've been following your guide on Fixing The Brightness Keys with BRT6.
I have created the following origin folder and opened SSDT-10-Sfgh.dsl and DSDT.dsl clicked patch pasted following but apply button got disabled.
If somebody can patch or can tell me what the problem is I'll be really happy.
Code:
into method label BRT6 replace_content
begin
    If (LEqual (Arg0, One))\n
    {\n
// Brightness Up\n
        Notify (^^LPCB.PS2K, 0x0406)\n
    }\n
    If (And (Arg0, 0x02))\n
    {\n
// Brightness Down\n
        Notify (^^LPCB.PS2K, 0x0405)\n
    }\n
end;
No BRT6 method found in your DSDT. This is why you cannot apply the patch. Attach your IOReg to check.
 

yigitkerem

Member
Joined
Mar 17, 2020
Motherboard
Lenovo V110-15IKB
CPU
i5-7200U
Graphics
UHD 620 + Disabled AMD R7 M240
OS X/macOS
10.15 (Beta)
Bootloader
Clover (UEFI)
Mobile Phone
iOS
How do I add it? And I don't know how to attach IOReg either.
 

Cyberdevs

Supervisor
Staff member
Joined
Aug 29, 2018
Motherboard
GA-Z170X-Gaming 5
CPU
Intel Core i7 6700K
Graphics
AMD Radeon Pro 580
OS X/macOS
10.14.6
Bootloader
Clover (UEFI)
Mobile Phone
iOS
How do I add it? And I don't know how to attach IOReg either.
Use this link to download the IORegistryExplorer and once you opened the app from the File menu select "Save" and then compress the saved file and post it here.
 

yigitkerem

Member
Joined
Mar 17, 2020
Motherboard
Lenovo V110-15IKB
CPU
i5-7200U
Graphics
UHD 620 + Disabled AMD R7 M240
OS X/macOS
10.15 (Beta)
Bootloader
Clover (UEFI)
Mobile Phone
iOS
It did not have an extension so I had to compress it.
 

Attachments

EliteMacx86

Administrator
Staff member
Joined
Jul 22, 2018
Motherboard
GIGABYTE Z370 AROUS GAMING 3
CPU
Intel Core i9 9900K
Graphics
2xAMD RX 580 8GB
OS X/macOS
10.14.6
Bootloader
Clover (UEFI)
Mac
MacBook Pro
Mobile Phone
Android, iOS
It did not have an extension so I had to compress it.
Your IOReg is corrupt. Use IOReg v2.1. However, i checked your IOReg using v3.0.2
The reason you're not able to apply the patch cause you're using BRT6 which doesn't exist in your DSDT. Your DSDT uses KBD0 instead.

The keys are Q1C and Q1D. So the patch would be this.

Code:
into method label _Q1C replace_content
begin
// Brightness Down\n
Notify (KBD0, 0x20)\n
end;

into method label _Q1D replace_content
begin
// Brightness Up\n
Notify (KBD0, 0x10)\n
end;
And your Brightness Hotkeys should work accordingly.
 

yigitkerem

Member
Joined
Mar 17, 2020
Motherboard
Lenovo V110-15IKB
CPU
i5-7200U
Graphics
UHD 620 + Disabled AMD R7 M240
OS X/macOS
10.15 (Beta)
Bootloader
Clover (UEFI)
Mobile Phone
iOS
So I open DSDT.dsl with macIASL click patch paste your code click export as ACPI Machine language and put the final file in CLOVER/ACPI/PATCED in EFI right that simple?
 

yigitkerem

Member
Joined
Mar 17, 2020
Motherboard
Lenovo V110-15IKB
CPU
i5-7200U
Graphics
UHD 620 + Disabled AMD R7 M240
OS X/macOS
10.15 (Beta)
Bootloader
Clover (UEFI)
Mobile Phone
iOS
Oh YEAH! That Simple!
final code
Code:
https://paste.ubuntu.com/p/PRvzMCzFwb/
And your Brightness Hotkeys should work accordingly.
And sure it does!

Done with the jokes but I might have missed a point in your article.
Your files have embedded External opcodes. No need for -da.
Disassemble with: iasl -dl DSDT.aml SSDT*.aml
Maybe Rehabman did not help a lot

Not mine but
Code:
https://www.tonymacx86.com/threads/solved-disassembling-acpi-could-not-parse-external-acpi-tables-ae_already_exists.265886/
got the same error.

So I had -da argument removed while decompiling it. It may help.
 

Attachments

Last edited:

EliteMacx86

Administrator
Staff member
Joined
Jul 22, 2018
Motherboard
GIGABYTE Z370 AROUS GAMING 3
CPU
Intel Core i9 9900K
Graphics
2xAMD RX 580 8GB
OS X/macOS
10.14.6
Bootloader
Clover (UEFI)
Mac
MacBook Pro
Mobile Phone
Android, iOS
So I open DSDT.dsl with macIASL click patch paste your code click export as ACPI Machine language and put the final file in CLOVER/ACPI/PATCED in EFI right that simple?
Yes, correct.
 

EliteMacx86

Administrator
Staff member
Joined
Jul 22, 2018
Motherboard
GIGABYTE Z370 AROUS GAMING 3
CPU
Intel Core i9 9900K
Graphics
2xAMD RX 580 8GB
OS X/macOS
10.14.6
Bootloader
Clover (UEFI)
Mac
MacBook Pro
Mobile Phone
Android, iOS
Oh YEAH! That Simple!
final code
Code:
https://paste.ubuntu.com/p/PRvzMCzFwb/
And sure it does!

Done with the jokes but I might have missed a point in your article.
Maybe Rehabman did not help a lot

Not mine but
Code:
https://www.tonymacx86.com/threads/solved-disassembling-acpi-could-not-parse-external-acpi-tables-ae_already_exists.265886/
got the same error.

So I had -da argument removed while decompiling it. It may help.
Yes, i already mentioned the same as a Notes in my guide. Credit goes to Rehabman. I've just made it simple to understand it more better.

I hope you can compile the DSDT as when i compiled, there was no any error.
 
Status
Not open for further replies.